Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to always enable source-maps #16

Closed
ForbesLindesay opened this issue Jul 24, 2014 · 1 comment · Fixed by browserify/browserify#910
Closed

Add option to always enable source-maps #16

ForbesLindesay opened this issue Jul 24, 2014 · 1 comment · Fixed by browserify/browserify#910

Comments

@ForbesLindesay
Copy link

I'm using uglifyify even in development for the dead code elimination. I'm defining constants that are always true or always false on the client so I can do things like:

if (IS_SERVER) {
  // do logic that only happens on the server
}

I can't seem to make uglifyify generate source maps unless the input already has a source map. In my case, the input is just pure JavaScript. Could we add an option to include source map comments?
@hughsk
Copy link
Owner

hughsk commented Jul 30, 2014

@ForbesLindesay 👍 I'd missed that this was happening seeing as I don't use sourcemaps myself! Once browserify/browserify#844 is sorted I'll enable sourcemaps when --debug is passed, plus offer a --sourcemaps option for backwards-compatability :)

@hughsk hughsk mentioned this issue Sep 19, 2014
Closed
hughsk added a commit to hughsk/node-browserify that referenced this issue Sep 19, 2014
@hughsk
Pass "flags" option to each transform
a59408c 
Essentially, "flags" is set to the value of the bundler's
"_options" property.

This should enable more intelligent transform behaviours,
for example toggling source maps when --debug is supplied
through the CLI or module API.

Closes browserify#844
Fixes hughsk/uglifyify#16
Fixes hughsk/uglifyify#18

This should enable more intelligent transform behaviours,
for example toggling source maps when --debug is supplied
through the CLI.' did not match any file(s) known to git.
hughsk added a commit to hughsk/node-browserify that referenced this issue Sep 19, 2014
@hughsk
Pass "flags" option to each transform
ea1d91e 
Essentially, "flags" is set to the value of the bundler's
"_options" property.

This should enable more intelligent transform behaviours,
for example toggling source maps when --debug is supplied
through the CLI or module API.

Closes browserify#844
Fixes hughsk/uglifyify#16
Fixes hughsk/uglifyify#18

This should enable more intelligent transform behaviours,
for example toggling source maps when --debug is supplied
through the CLI.' did not match any file(s) known to git.
hughsk added a commit to hughsk/node-browserify that referenced this issue Sep 19, 2014
@hughsk
Pass "flags" option to each transform
e92b000 
Essentially, "flags" is set to the value of the bundler's
"_options" property.

This should enable more intelligent transform behaviours,
for example toggling source maps when --debug is supplied
through the CLI or module API.

Closes browserify#844
Fixes hughsk/uglifyify#16
Fixes hughsk/uglifyify#18

This should enable more intelligent transform behaviours,
for example toggling source maps when --debug is supplied
through the CLI.
hughsk added a commit to hughsk/node-browserify that referenced this issue Sep 19, 2014
@hughsk
Pass "flags" option to each transform
732e6a9 
Essentially, "flags" is set to the value of the bundler's
"_options" property.

This should enable more intelligent transform behaviours,
for example toggling source maps when --debug is supplied
through the CLI or module API.

* Closes browserify#844
* Fixes hughsk/uglifyify#16
* Fixes hughsk/uglifyify#18
@hughsk hughsk mentioned this issue Sep 19, 2014
Merged
@hughsk hughsk closed this as completed in 154a547 Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass "flags" option to each transform hughsk/node-browserify
2 participants
@hughsk @ForbesLindesay