Update dependencies #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where using source maps with older versions of uglify generates tons of warnings. Using source maps with older versions of uglify generates many (~7000 for my SPA) warnings that look like: ``` WARN: Couldn't figure out mapping for ?:62,2 → 1,1611 [] WARN: Couldn't figure out mapping for ?:62,15 → 1,1613 [] WARN: Couldn't figure out mapping for ?:63,4 → 1,1648 [] WARN: Couldn't figure out mapping for ?:68,9 → 1,1690 [] ... ``` This is due to a [bug in the `source-map` library][bug] which is a dependency of `uglify-js`. Restricting `uglify-js` and `convert-source-map` to newer versions ensures that incompatible versions of `source-map` are not installed. [bug]: mishoo/UglifyJS#436
| "extend": "^1.2.1", | ||
| "minimatch": "^2.0.7", | ||
| "through": "~2.3.4", | ||
| "uglify-js": "2.x.x" | ||
| "uglify-js": "^2.5.x" |
There was a problem hiding this comment.
why not 2.7.x? Let's update it to the latest version
|
There is a problem with |
|
I wanted to submit the most conservative change possible (so as not to affect others), but if it'll get a thumbs up from one of the maintainers I'm happy to bump the @hughsk any objections to |
|
@hughsk any chance you can take a couple minutes to review this? |
|
Closing this as it's no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where using source maps with older versions of uglify generates
tons of warnings.
Using source maps with older versions of uglify generates many (~7000 for my
SPA) warnings that look like:
This is due to a bug in the
source-maplibrary which is a dependencyof
uglify-js.Restricting
uglify-jsandconvert-source-mapto newer versions ensures thatincompatible versions of
source-mapare not installed.