Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix github security warning #93

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Fix github security warning #93

merged 1 commit into from
Aug 20, 2019

Conversation

goto-bus-stop
Copy link
Contributor

use xtend, already common in browserify installs

@icetee
Copy link

icetee commented Feb 15, 2019 •
edited
Loading

Or simply upgrade extend plugin @hughsk - This is security issue https://nvd.nist.gov/vuln/detail/CVE-2018-16492!

@StudioSpindle StudioSpindle mentioned this pull request Feb 27, 2019
Open
@rhagarty
Copy link

Anyone looking into this?

@oleavr
Copy link

oleavr commented May 1, 2019

The simpler fix is to drop the dependency and use Object.assign(), which has been available since Node.js 4.x.

@lorentzlasson lorentzlasson mentioned this pull request May 27, 2019
Open
@ankurkaushal
Copy link

Any updates on this? :)

@goto-bus-stop
Copy link
Contributor Author

goto-bus-stop commented Aug 2, 2019 •
edited
Loading

No. i will ask around.

Note that this issue in the extend dependency does not affect uglifyify at all, so it's absolutely safe to ignore the warning until this lands.

yoshuawuyts
yoshuawuyts approved these changes Aug 20, 2019
View reviewed changes
Copy link
Collaborator

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoshuawuyts yoshuawuyts merged commit 662f60a into hughsk:master Aug 20, 2019
@yoshuawuyts
Copy link
Collaborator

v5.0.2 🎉

@goto-bus-stop goto-bus-stop deleted the xtend branch August 20, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@goto-bus-stop @icetee @rhagarty @oleavr @ankurkaushal @yoshuawuyts