Merge pull request #3289 from huginn/fix_parse_body_validation

Fix the validation for parse_body
huginn · Jul 4, 2023 · cc1f8c7 · cc1f8c7
2 parents 61be669 + 265525a
commit cc1f8c7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/app/models/agents/post_agent.rb b/app/models/agents/post_agent.rb
@@ -144,7 +144,7 @@ def validate_options
         errors.add(:base, "if provided, output_mode must be 'clean' or 'merge'")
       end
 
-      if options['parse_body'].present? && /\A(?:true|false)\z|\{/.match?(options['parse_body'].to_s)
+      if options['parse_body'].present? && !/\A(?:true|false)\z|\{/.match?(options['parse_body'].to_s)
         errors.add(:base, "if provided, parse_body must be 'true' or 'false'")
       end
 

diff --git a/spec/models/agents/post_agent_spec.rb b/spec/models/agents/post_agent_spec.rb
@@ -303,6 +303,7 @@
 
           it "emits the parsed JSON body when parse_body is true" do
             @checker.options['parse_body'] = 'true'
+            @checker.save!
             @checker.check
             expect(@checker.events.last.payload['body']).to eq json_data
           end