Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace therubyracer with execjs (if possible) #1959

Closed
0xdevalias opened this issue Apr 9, 2017 · 2 comments
Closed

Replace therubyracer with execjs (if possible) #1959

0xdevalias opened this issue Apr 9, 2017 · 2 comments

Comments

@0xdevalias
Copy link
Member

So thinking about therubyracer/mini_racer stuff in #1919 lead me to finding out about https://github.com/rails/execjs

Essentially, it seems to be a wrapper around all the possible ruby JS implementations.

Theoretically, that means that we should be able to rip out the current direct binding to therubyracer, and replace it with execjs, and have everything just work.

Creating this separate issue so it doesn't get stuck in my dockerfile rewrite stuff.

Is this something anyone else would like to tackle? Shouldn't be overly difficult, but i'm well aware of my time pressures at the moment, and so not sure I will get to it in any sort of reasonable timeframe at the moment.

@dsander
Copy link
Collaborator

dsander commented Apr 9, 2017

I don't think that will work. execjs only allows to execute javascript code, but we are also adding functions which will always be specific to the javascript runtime. I will have a look at mini_racer, it sounds like it would both speed up asset precompilation as well as the JavascriptAgent.

dsander added a commit to dsander/huginn that referenced this issue Apr 9, 2017
dsander added a commit to dsander/huginn that referenced this issue Apr 9, 2017
@0xdevalias 0xdevalias changed the title Replace therubyracer with execjs Replace therubyracer with execjs (if possible) Apr 10, 2017
@0xdevalias
Copy link
Member Author

I'm going to close this for now, in light of #1961 Can reopen again later if required.

dsander added a commit to dsander/huginn that referenced this issue May 21, 2017
dsander added a commit to dsander/huginn that referenced this issue Jan 24, 2018
dsander added a commit to dsander/huginn that referenced this issue Oct 23, 2018
dsander added a commit to dsander/huginn that referenced this issue Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants