Use Pirate Weather with the Weather Agent #3317
Merged
+1,918
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d "darksky" version
knu
reviewed
Nov 3, 2023
|
@knu thanks for reviewing! No problem- I'll fix those formatting bits |
alexcochran
force-pushed
the
pirate-weather
branch
from
1a3a0d8
to
4726aa0
Compare
|
@knu I reset to the previous commit on my branch + only kept the changes to the README under the WeatherAgent section. Please let me know if I need to fix anything else |
knu
approved these changes
Nov 20, 2023
That's a good point. Thank you for the reminder to do that in future PRs. |
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2732 by replacing Dark Sky with Pirate Weather, as suggested by @virtadpt.
Uses pirate_forecast_weather_ruby as a drop-in replacement for the existing ForecastIO module provided by Dark Sky.
NOTE: I couldn't get the coveralls step to pass, but @cantino mentioned it wasn't due to my changes. I added it back before opening.