Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Sky End of Life: 2021 #2732

Closed
ghost opened this issue Apr 2, 2020 · 19 comments · Fixed by #3317
Closed

Dark Sky End of Life: 2021 #2732

ghost opened this issue Apr 2, 2020 · 19 comments · Fixed by #3317

Comments

@ghost
Copy link

ghost commented Apr 2, 2020

For those who've missed it, Dark Sky will be going End of Life at "the end of 2021." I'm not sure what global alternatives there are, but Americans can take advantage of weather.gov's API fairly easy.

The default weather agent will need to be replaced with something else before the end of 2021.

@ghost ghost mentioned this issue Apr 2, 2020
48 tasks
@ghost
Copy link
Author

ghost commented Apr 2, 2020

I suppose https://github.com/public-apis/public-apis#weather would be a good resource to review.

@virtadpt
Copy link
Collaborator

virtadpt commented Apr 3, 2020

I've been using the NWS' API for a while. Have some sample agent code for it handy.

@e-alfred
Copy link

e-alfred commented Apr 4, 2020

Openweathermap works pretty well.

@seigel
Copy link

seigel commented Apr 6, 2020

weatherbit seems to have a free tier...I am looking to see if I can wrangle an "fix" together..

@cantino
Copy link
Member

cantino commented Jun 24, 2020

@virtadpt, do you want to contribute an improvement to the WeatherAgent?

@snus-kin
Copy link

FYI you can no longer sign up for a darksky API key

@erebor
Copy link
Contributor

erebor commented Jul 28, 2020

Anybody had a chance to look at my PR for switching the WeatherAgent to Openweather? I'm not sure the correct way to get on somebody's radar for this other than pushing up code.

@xthursdayx
Copy link

Hi folks, just wondering what the state of this issue (and associated PR) are? Has any progress been made to update the weather API options?

@ghost
Copy link
Author

ghost commented Jun 20, 2022

Apple has determined that they will manage DarkSky under a new name (and you'll have to pay the Apple Developer fee of $100/yr): WeatherKit

@virtadpt
Copy link
Collaborator

This might be a good time to write an Agent class for https://api.weather.gov/

@virtadpt
Copy link
Collaborator

virtadpt commented Jan 6, 2023

Pirate Weather has an APi designed to be a drop-in replacement for the Darksky API. API keys are free. Maybe this would be a useful stopgap?

@cantino
Copy link
Member

cantino commented Jan 15, 2023

Have you tried it @virtadpt? That's an elegant solution.

@virtadpt
Copy link
Collaborator

@cantino I haven't yet. I've been using the NWS API for a while and haven't migrated over yet.

@IBakeCookies
Copy link

IBakeCookies commented May 19, 2023

Hello! I am a little bit confused on this one, I suppose there hasnt been any progress here?

@alexcochran
Copy link
Contributor

alexcochran commented Sep 11, 2023

Howdy! I went ahead and adapted the forecast-ruby gem to create pirate-weather-forecast-ruby. As the name suggests, pirate-weather-forecast-ruby uses the Pirate Weather API as a replacement for Dark Sky's API.

Tests and everything else are currently working, so now I'm just trying to get Huginn wired up to use the new gem. Once that's done I can make a PR to swap the lib.

I'll also make some efforts to clean up my code on the adapter once I have time.

@alexcochran
Copy link
Contributor

I think I'm getting close. I can get the tests to pass, but the Coveralls action in the GitHub workflow is failing w/ Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}:

image

@cantino @knu I admit I'm pretty inexperienced w/ Coveralls + Rails. Am I missing something here?

@cantino
Copy link
Member

cantino commented Sep 14, 2023

Hey @alexcochran, that doesn't look like something you broke. You might be able to skip the coveralls step and see if everything else works.

@alexcochran
Copy link
Contributor

alexcochran commented Sep 17, 2023

Thanks @cantino. I commented out Coveralls from the GitHub CI config and everything seems to work:

image

Should I go ahead and make a PR?

@cantino
Copy link
Member

cantino commented Sep 19, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants