Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SMTP config regression when not using authentication #1663

Merged
merged 1 commit into from
Sep 3, 2016

Conversation

dsander
Copy link
Collaborator

@dsander dsander commented Sep 1, 2016

user_name and password need to be set to nil when no authentication should be performed

Fixes #1657

`user_name` and `password` need to be set to nil when no authentication should be performed

Fixes huginn#1657
@cantino
Copy link
Member

cantino commented Sep 2, 2016

LGTM. It might be nice to also add a magic "none" value for SMTP_AUTHENTICATION that makes it nil as well, since @virtadpt said he needed to set it to SMTP_AUTHENTICATION= in your .env to make this work?

@dsander
Copy link
Collaborator Author

dsander commented Sep 2, 2016

I don't think that is needed, we defaulted to plain before the config change, Net::SMTP is only running the authentication when a user is passed.

@cantino
Copy link
Member

cantino commented Sep 2, 2016

LGTM then

@dsander dsander merged commit 15dd513 into huginn:master Sep 3, 2016
@dsander dsander deleted the fix-smtp-config-regression branch September 3, 2016 08:07
@dsander
Copy link
Collaborator Author

dsander commented Sep 3, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants