Fix escape characters of events when dry running #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah! Great fix. +1 |
|
Good catch. Maybe a spec would be good to explain why this is needed? |
JSONEditor double escapes escape characters to properly display them in the UI, however when dry running Agents we actually need to send the Event's characters as they were. Before an event containing new lines like this `Line A\nLineB` would be send as `Line A\\nLineB` to the backend. By replacing the double escaped slashes we ensure the event is handled as it would be when not dry running. huginn#1677
dsander
force-pushed
the
fix-dry-run-event-escaping
branch
from
dcf7a55
to
4309460
Compare
|
Added a spec, I initially wanted to do it in the rails5 PR because it already had dry run specs but it makes more sense to keep it in the right context. |
|
Nice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSONEditor double escapes escape characters to properly display them in the UI, however when dry running Agents we actually need to send the Event's characters as they were.
Before an event containing new lines like this
Line A\nLineBwould be send asLine A\\nLineBto the backend. By replacing the double escaped slashes we ensure the event is handled as it would be when not dry running.#1677