Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new option include_sort_info #1772

Merged
merged 1 commit into from
Dec 31, 2016
Merged

Add a new option include_sort_info #1772

merged 1 commit into from
Dec 31, 2016

Conversation

knu
Copy link
Member

@knu knu commented Nov 2, 2016

If enabled, all events created by the Agent will have a sort_info key whose value is a hash containing the keys position and count.

This overrides #1768.

@dsander
Copy link
Collaborator

dsander commented Nov 2, 2016

I think this approach is much easier to understand and use than #1768. 👍

@cantino
Copy link
Member

cantino commented Nov 2, 2016

Looks good!

@knu
Copy link
Member Author

knu commented Nov 3, 2016

Thanks, I'll fix the failures later today to get ready for a merge.

@knu
Copy link
Member Author

knu commented Nov 3, 2016

Seems spec/controllers/http_status_agent_spec.rb is doing things weirdly... It overrides many internal methods instead of stubbing requests, it randomly uses UUIDs as URLs and header values, etc. I think I need to invest some time to rewrite it.

@knu knu mentioned this pull request Nov 4, 2016
If enabled, all events created by the Agent will have a `sort_info` key
whose value is a hash containing the keys `position` and `count`.

This overrides #1768.
@knu knu merged commit a824bc9 into master Dec 31, 2016
@knu knu deleted the include_sort_info branch December 31, 2016 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants