Make DataOutputAgent serve RSS output as application/rss+xml
#1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cantino
reviewed
Apr 19, 2017
| @@ -165,6 +166,10 @@ def feed_description | |||
| interpolated['template']['description'].presence || "A feed of Events received by the '#{name}' Huginn Agent" | |||
| end | |||
|
|
|||
| def rss_content_type | |||
| interpolated['rss_content_type'] || 'application/rss+xml' | |||
There was a problem hiding this comment.
maybe interpolated['rss_content_type'].presence || 'application/rss+xml' to ignore blanks?
For backward compatibility, a new option `rss_content_type` is added and existing agents will have its value set to `text/xml`, which was the Content-Type value before this change. This fixes #1968.
|
@cantino Thanks, fixed. |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For backward compatibility, a new option
rss_content_typeis added and existing agents will have its value set totext/xml, which was the Content-Type value before this change.This fixes #1968.