Upgrade liquid #1982
Upgrade liquid #1982
Conversation
app/models/agents/sleep_agent.rb
Outdated
| @@ -0,0 +1,21 @@ | |||
| module Agents | |||
| class SleepAgent < Agent | |||
There was a problem hiding this comment.
@dsander did you mean to include this?
|
Makes sense to me, although I haven't dug into the Liquid BlockBody class. Anything else we should test? |
|
@cantino The test coverage looks pretty good for the @knu Could you give it a second look? I more or less followed the changes the liquid team did to their own tags but noticed the node_list method was not called before and isn't now. Do you remember why it was added? |
|
👍 |
|
@dsander The |
| @@ -386,21 +386,27 @@ def initialize(tag_name, markup, tokens) | |||
| else | |||
| raise Liquid::SyntaxError, 'Syntax Error in regex_replace tag - Valid syntax: regex_replace pattern in' | |||
| end | |||
| @nodelist = @in_block = [] | |||
| @with_block = nil | |||
There was a problem hiding this comment.
I think it's better not to remove this initialization, because it was there to avoid a runtime warning about reference to an uninitialized instance variable when $VERBOSE is turned on.
There was a problem hiding this comment.
Alright, I did not know about those warnings.
|
@knu Thanks for the clarification and review! |
|
Thanks @dsander! |
Fixes #1981