Change docker image namespace #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks @dsander! The code looks good; I haven't tested the display in Docker. |
|
Sorry I meant to attach a screenshot: |
|
Nice |
For now we keep pushing to the old namespace but add a warning to users a chance to change their images to the new namespace.
dsander
force-pushed
the
change-docker-image-namespace
branch
from
27e1c7e
to
94d2b8e
Compare
|
Thanks, I actually forgot to enable the new images in the build matrix but we should be good now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we keep pushing to the old namespace but add a warning to users a chance to change their images to the new namespace.
After a few weeks/months we could change the
cantino/huginn*to a dummy webserver which serves a static page pointing the user to the new image or simply remove them.