add itunes podcast icon #2114
Merged
add itunes podcast icon #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knu
requested changes
Sep 6, 2017
| @@ -296,6 +296,7 @@ def receive_web_request(params, method, format) | |||
| <atom:link href=#{feed_url(secret: params['secret'], format: :xml).encode(xml: :attr)} rel="self" type="application/rss+xml" /> | |||
| <atom:icon>#{feed_icon.encode(xml: :text)}</atom:icon> | |||
| #{hub_links} | |||
| <itunes:image href=#{feed_icon.encode(xml: :attr)} /> | |||
There was a problem hiding this comment.
I think this should be added only if boolify(interpolated['ns_itunes']) is true, because it is the option to enable the itunes namespace.
There was a problem hiding this comment.
Yup that makes sense - changes have been implemented
|
@knu Yup makes sense - I've implemented those changes... |
knu
approved these changes
Sep 7, 2017
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.