Make TelegramAgent FormConfigurable, DryRunable and add logging #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knu
approved these changes
Oct 1, 2017
app/models/agents/telegram_agent.rb
Outdated
| @@ -68,18 +84,23 @@ def telegram_bot_uri(method) | |||
| end | |||
|
|
|||
| def receive_event(event) | |||
| TELEGRAM_ACTIONS.each do |field, method| | |||
| messages_send = TELEGRAM_ACTIONS.map do |field, method| | |||
There was a problem hiding this comment.
Maybe you could say messages_sent = TELEGRAM_ACTIONS.count do |field, method| here and change the condition below from if messages_send.empty? to if messages_sent.zero?.
Makes the Agent easier to use and to debug. It now verifies the API token and auto completes the `chat_id`. Log entries are only created on failure to avoid cluttering the Agent log. huginn#2135
dsander
force-pushed
the
improve-telegram-agent
branch
from
ce842d9
to
da72ecd
Compare
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the Agent easier to use and to debug. It now verifies the API token and auto completes the
chat_id.Log entries are only created on failure to avoid cluttering the Agent log.
#2135