Add ability to publish media on Twitter #2161
Conversation
qwertme
changed the title
| @@ -59,7 +61,8 @@ def receive(incoming_events) | |||
| end | |||
| end | |||
|
|
|||
| def publish_tweet(text) | |||
| def publish_tweet(text, media) | |||
| return twitter.update_with_media(text, File.new(open(media))) unless media.blank? | |||
There was a problem hiding this comment.
I assume we are requiring open-uri somewhere and this also works with URLs?
There was a problem hiding this comment.
I presume it is required by rails.
I am not entirely satisfied with the test coverage to be honest. I would have liked to refactor the test to stub the twitter API instead of the publish_tweet method so the internals of this method would have been covered. Maybe when I have more time.
There was a problem hiding this comment.
We do require it in a few files, I think it would make sense to either move the requires to an initializer or add it to this Agent as well.
I would have liked to refactor the test to stub the twitter API instead of the publish_tweet method so the internals of this method would have been covered. Maybe when I have more time.
Good idea!
|
Tried and it works on my instance. Is the |
Just a quick fix to allow posting images to Twitter.