Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better validations for the weather agent. #2414

Merged
merged 3 commits into from
Nov 14, 2018

Conversation

dscottboggs
Copy link
Contributor

This PR adds better validations, error messages, and parsing of the location when using the darksky provider for the weather agent.

Copy link
Collaborator

@dsander dsander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

expect(dark_sky_agent).to be_valid
end
it "fails cases that pass the first test but are invalid" do
dark_sky_agent.options["location"] = "137.779329, -122.41915" # too high latitude
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indentation looks off

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh my text editor was being difficult, sorry I missed that.

@dsander dsander merged commit d8da1a8 into huginn:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants