Upgrade devise to fix CVE #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CVE-2019-5421 More information moderate severity Vulnerable versions: < 4.6.0 Patched version: 4.6.0 Devise ruby gem before 4.6.0 when the lockable module is used is vulnerable to a time-of-check time-of-use (TOCTOU) race condition due to increment_failed_attempts within the Devise::Models::Lockable class not being concurrency safe. heartcombo/devise#4981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump devise to fix CVE in lockable logic
CVE-2019-5421
More information
moderate severity
Vulnerable versions: < 4.6.0
Patched version: 4.6.0
Devise ruby gem before 4.6.0 when the lockable module is used is
vulnerable to a time-of-check time-of-use (TOCTOU) race condition due to
increment_failed_attempts within the Devise::Models::Lockable class not
being concurrency safe.
heartcombo/devise#4981
Upgrade shoulda-matchers to get rid of deprecation warning