Add group_by liquid filter
#2572
Conversation
|
Nice, this looks very handy! |
| if input.respond_to?(:group_by) | ||
| [].tap do |grouped| | ||
| input.group_by { |item| item[property] }.each do |value, items| | ||
| grouped << { 'name' => value, 'items' => items } |
There was a problem hiding this comment.
I'm not absolutely sure if name/items are the best choices here. key/values, maybe?
There was a problem hiding this comment.
I noticed that jekyll which has the same filter (although they have shared code between filters, thus I simplified it here and provided a simpler implementation).
Thus, I decided to use the same key names, since that is quite a popular project and thus provides some sort of "standard". I agree that it's a bit strange, but it makes sense when you think of it as "name of the group" and "items in the group". Liquid is meant for somewhat non-technical people and designers, after all.
But in the end, I'm not tied to anything. It's a judgement-call.
|
Thank you! The CI failure was unrelated. |
|
Almost forgot about it, can you add the filter to the wiki page? |
|
All done |
Something which should really be a part of liquid core, but unfortunately isn't.
I had a need for this when using the LiquidOutputAgent to organize events by day.