Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mail template param #2881

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MarkBarbieri
Copy link

Proposing the following to allow complex/custom html or text email templates.

May be an alternate solution to #2541

This allows for a complete custom template to be defined and referenced in the EmailAgent options

Copy link
Collaborator

@dsander dsander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @MarkBarbieri!

I don't think that is a good solution, users should not need to put files on the server Huginn runs on to use templates. credentials could be an option that works for users with different installation methods like docker

@dsander dsander requested a review from knu December 21, 2020 23:36
@MarkBarbieri
Copy link
Author

credentials could be an option that works for users with different installation methods like docker

I'd like to know more about how this would work to solve my problem. This proposed change isn't about supporting different installation methods, it's to provide an option for more richly formatted messages, for example, custom css, etc.

I'm using Huginn for monitoring rss feeds, etc, and some of the content from the feed does not format well, so I want to provide custom css in the header, with a custom footer. I don't want to sanitize the body, which is forced in the current template.

This might be a little bespoke, but seems useful to me and for what I've been doing, it's worked fantastically without disrupting any other normal use.

@MarkBarbieri
Copy link
Author

Thank you for your contribution @MarkBarbieri!

I don't think that is a good solution, users should not need to put files on the server Huginn runs on to use templates. credentials could be an option that works for users with different installation methods like docker

@dsander It's been a long time coming, but I've updated this PR so that the template can be defined inline using credentials. It is no longer required to put files on the server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants