Add SchedulerAgent, which periodically runs other agents. #459

knu · 2014-08-22T04:47:15Z

This is the core part of the solution to #444. As the first step, I've implemented SchedulerAgent that supports cron-style schedule. User can create SchedulerAgents as many as they want and bind target Agents to it. A master scheduler job in HuginnScheduler periodically checks for SchedulerAgents to create/update/delete the corresponding jobs as necessary.

We can add some additional agents later if needs be:

CalendarAgent: Runs target Agents if it is currently free or busy now in specified calendar(s).
RunnerAgent: Runs target Agents when it receives an event.

How do you feel about this direction?

…nts.

cantino · 2014-08-22T05:50:36Z

This is very interesting.

Do you see different types of Agents needing to trigger other Agents as well? Generally, Agents are triggered by incoming events, but I can imagine that having a side-channel method of running Agents could be useful in the future. If we're going to make it generic-- chains and targets-- then we should be sure that there are enough use cases beyond the SchedulerAgent. Otherwise, a new Schedule object could have many Agents, but not be an Agent itself. What other uses do we foresee?

knu · 2014-08-22T06:37:48Z

@cantino Yes, I have at least two in my mind as I named above. Their supposed use cases include the following:

A RunnerAgent that receives events from a PeakDetectorAgent and runs a WebsiteAgent: to crawl a news site to check for headlines immediately after some peak is detected.
A SchedulerAgent that runs a CalendarAgent that runs an agent to check the status of bus service: to get alerted of bus approaching only on a non-holiday weekdays, where the SchedulerAgent runs the CalendarAgent every 30 seconds in the morning on weekdays that checks the national holiday calendar (which should of course be cached for some time) to run the target agent only if it is not a holiday.

knu · 2014-08-22T06:44:25Z

The only action that these "runner" agents take at the moment is "run", but there could also be "disable" and "enable". Agents that can run other agents may have options['action'] defaulted to "run" if we allow those additional actions.

cantino · 2014-08-22T06:48:14Z

That makes sense. I'll play with this and do a deeper review of the code soon!

This is done in preparation for adding an ability for an agent to enable or disable other agents other than running.

cantino · 2014-08-23T02:12:48Z

.env.example

+# SchedulerAgent.  By default, the use of the "second" field is
+# restricted so that any value other than a single zero (which means
+# "on the minute") is disallowed.
+ENABLE_SECOND_PRECISION_SCHEDULE=false


Is this to prevent DOS?

Yes, you can still create as many agents as you want, though, I suppose only allowing an agent to run on the minute would demotivate potential abusers. Should I note that here?

I guess? I suppose we could allow every 15 or 30 seconds. What do you think?

That is fine as long as you can document that nicely in the description. I cheated by omitting the seconds part completely. 😁

OK, multiples of fifteen are now allowed even when the option is disabled (default).

Conflicts: app/helpers/agent_helper.rb db/schema.rb

knu · 2014-08-29T08:34:32Z

@cantino The s/target/control_target/g part is done. What do you think about the table name? #459 (comment)

coveralls · 2014-08-29T08:44:35Z

Coverage increased (+0.05%) when pulling 05dd52d on knu:scheduler_agent into 4c938f1 on cantino:master.

cantino · 2014-09-03T03:36:18Z

lib/huginn_scheduler.rb

+
+  class Job
+    # Store an ID of SchedulerAgent in this job.
+    def scheduler_agent_id= id


() please around the arguments.

…rialized.

Conflicts: db/schema.rb

cantino · 2014-09-04T02:15:04Z

Looks great to me! Let me deploy this to my setup and let it run for a few days, then I think we'd be good to merge. Is there anything else you wanted to add to this?

cantino · 2014-09-04T02:25:19Z

If controlling Agents have a "Control targets" list, why do other Agents need to have a "Controllers" list. It seems like it'd make sense to have one or the other.

knu · 2014-09-04T02:35:26Z

@cantino I'll make the field read-only then. When cloning an agent that has controllers, it may be important for user to see them in the form before saving it.

coveralls · 2014-09-04T05:33:28Z

Coverage decreased (-0.72%) when pulling 23b0741 on knu:scheduler_agent into 5a82064 on cantino:master.

knu · 2014-09-04T06:10:56Z

@cantino I think it's done by now!

cantino · 2014-09-04T06:36:36Z

Awesome! I'll play with it for a day or two and we can get it out :)

cantino · 2014-09-06T02:54:24Z

Seems to be working well!

knu · 2014-09-08T04:49:37Z

OK, so I'm going to merge this later and take the next step forward!

cantino · 2014-09-08T05:31:04Z

Sounds good!

knu · 2014-09-08T09:13:15Z

Done! Should cover #67.

knu · 2014-09-08T09:23:32Z

This thread was closed, but I've added Agent ideas found here to the list in #353.

knu added 5 commits August 21, 2014 22:57

Add "chains" to represent runner-target relationships between Agents.

c7e67a3

Provide a target agent select box for an agent that can run other age…

b4636f8

…nts.

Show target-runner relationships in a diagram.

0ae0f1a

Add SchedulerAgent, which periodically runs other agents.

e9fa1f2

Add a spec for how the before_save hook should work.

26564c5

knu added 6 commits August 22, 2014 16:05

Store an agent ID in the local storage rather than stashing it in a tag.

f6d1966

Fix the schema version.

56fa4cb

Rename "runner" to "controller".

de5619f

This is done in preparation for adding an ability for an agent to enable or disable other agents other than running.

Improve the description.

a069fa6

Disable second precision schedule by default to prevent service abuse.

0f66669

Add control action types "enable" and "disable".

a479573

cantino reviewed Aug 23, 2014
View reviewed changes

Use error for error, not log.

a2e1348

0xdevalias added the agent label Aug 23, 2014

knu added 5 commits August 27, 2014 23:57

Merge branch 'master' into scheduler_agent

806e41d

Conflicts: app/helpers/agent_helper.rb db/schema.rb

Fix specs for the new stuff in DOT output.

d0d9c8e

Rename "target" to "control target".

3004170

Merge remote-tracking branch 'origin/master' into scheduler_agent

1cea2ba

Fix a bug with edge line styling.

05dd52d

cantino mentioned this pull request Sep 1, 2014

Official Agent Suggestions Thread #353

Open

48 tasks

cantino reviewed Sep 3, 2014
View reviewed changes

knu added 12 commits September 3, 2014 12:48

Compare user_id's rather than user objects.

95a067a

Use length rather than count when the relation should already be mate…

06ae684

…rialized.

Fix control-link-region display toggling.

46497f0

Add can_control_other_agents to the response hash of type_details.

69d2273

Clone controller_target_ids too.

706ce8d

Add NOT NULL contraints.

9a7f7fe

Add some specs for our Rufus::Scheduler extension.

51f8c8b

Set a created job's scheduler_agent_id before it is first triggered.

53eb531

Parenthesize the argument.

77f03da

Merge remote-tracking branch 'origin/master' into scheduler_agent

8dc5244

Conflicts: db/schema.rb

Update db/schema.rb.

99c3fc0

Squash migrations during the development of the scheduler_agent branch.

12f1839

knu added 3 commits September 4, 2014 13:55

Make the "Controllers" field read-only.

38de860

Oops, 30 is a multiple of fifteen.

786b0f3

When the control action is run, control targets must be schedulable.

23b0741

knu merged commit 23b0741 into huginn:master Sep 8, 2014

knu deleted the scheduler_agent branch September 10, 2014 02:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SchedulerAgent, which periodically runs other agents. #459

Add SchedulerAgent, which periodically runs other agents. #459

knu commented Aug 22, 2014

cantino commented Aug 22, 2014

knu commented Aug 22, 2014

knu commented Aug 22, 2014

cantino commented Aug 22, 2014

cantino Aug 23, 2014

knu Aug 23, 2014

cantino Aug 29, 2014

knu Aug 29, 2014

knu Sep 2, 2014

knu commented Aug 29, 2014

coveralls commented Aug 29, 2014

cantino Sep 3, 2014

knu Sep 3, 2014

cantino commented Sep 4, 2014

cantino commented Sep 4, 2014

knu commented Sep 4, 2014

coveralls commented Sep 4, 2014

knu commented Sep 4, 2014

cantino commented Sep 4, 2014

cantino commented Sep 6, 2014

knu commented Sep 8, 2014

cantino commented Sep 8, 2014

knu commented Sep 8, 2014

knu commented Sep 8, 2014

Add SchedulerAgent, which periodically runs other agents. #459

Add SchedulerAgent, which periodically runs other agents. #459

Conversation

knu commented Aug 22, 2014

cantino commented Aug 22, 2014

knu commented Aug 22, 2014

knu commented Aug 22, 2014

cantino commented Aug 22, 2014

cantino Aug 23, 2014

Choose a reason for hiding this comment

knu Aug 23, 2014

Choose a reason for hiding this comment

cantino Aug 29, 2014

Choose a reason for hiding this comment

knu Aug 29, 2014

Choose a reason for hiding this comment

knu Sep 2, 2014

Choose a reason for hiding this comment

knu commented Aug 29, 2014

coveralls commented Aug 29, 2014

cantino Sep 3, 2014

Choose a reason for hiding this comment

knu Sep 3, 2014

Choose a reason for hiding this comment

cantino commented Sep 4, 2014

cantino commented Sep 4, 2014

knu commented Sep 4, 2014

coveralls commented Sep 4, 2014

knu commented Sep 4, 2014

cantino commented Sep 4, 2014

cantino commented Sep 6, 2014

knu commented Sep 8, 2014

cantino commented Sep 8, 2014

knu commented Sep 8, 2014

knu commented Sep 8, 2014