Skip to content
This repository has been archived by the owner on Jul 12, 2018. It is now read-only.

nit: use close opcode constant #1

Merged
merged 2 commits into from Mar 12, 2018

Conversation

vigneshshanmugam
Copy link
Contributor

@vigneshshanmugam vigneshshanmugam commented Mar 11, 2018

I am reading the source code since I started with the same idea last week https://github.com/vigneshshanmugam/turbo-ws-server and I plan to contribute here instead :)

@coveralls
Copy link

coveralls commented Mar 11, 2018

Pull Request Test Coverage Report for Build 25

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.169%

Totals Coverage Status
Change from base Build 21: 0.0%
Covered Lines: 154
Relevant Lines: 232

💛 - Coveralls

@hugmanrique
Copy link
Owner

LGTM! Thanks for your help. Will merge when you change that comparison

@vigneshshanmugam
Copy link
Contributor Author

Can you tell me which comparison you are referring to?

@hugmanrique
Copy link
Owner

The constants file has a helper function to check if an opCode is a control opCode. Instead of performing the validation manually (which might change in future versions) we could use that func.

@vigneshshanmugam
Copy link
Contributor Author

Cool, done

@hugmanrique
Copy link
Owner

Thanks for the PR! 😀

@hugmanrique hugmanrique reopened this Mar 12, 2018
@hugmanrique hugmanrique merged commit 0c0d09d into hugmanrique:master Mar 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants