Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Hashtag character in tags, can it be escaped ? #245

Closed
Kapusch opened this issue Nov 17, 2022 · 6 comments
Closed

[BUG] Hashtag character in tags, can it be escaped ? #245

Kapusch opened this issue Nov 17, 2022 · 6 comments
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@Kapusch
Copy link
Contributor

Kapusch commented Nov 17, 2022

Describe the bug 描述你遇到的错误

Hi, first I would like to thank you for maintaining this theme which I'm experimenting for few weeks.

I encountered the following issue where my tag is not rendered in the UI:
image

And I think it's because it contains a hashtag character inside, as you can see from my Front Matter property:
Tags: ["C# markup","Grid"]

Expected behavior 期待的行为

All my tags should be rendered and any unexpected character should be escaped.
Do you think it should be fixed in the template itself or Is there any workaround ?

@Kapusch Kapusch added the bug Something isn't working label Nov 17, 2022
@Lruihao Lruihao added this to To do in Roadmap via automation Nov 18, 2022
@Lruihao Lruihao self-assigned this Nov 18, 2022
@Lruihao Lruihao added this to the v0.2.17 milestone Nov 18, 2022
@Lruihao
Copy link
Member

Lruihao commented Nov 18, 2022

@Kapusch Thanks for your feedback, this bug has been fixed.

@Lruihao Lruihao closed this as completed Nov 18, 2022
Roadmap automation moved this from To do to Done Nov 18, 2022
@Lruihao
Copy link
Member

Lruihao commented Nov 19, 2022

reopen with #246

@Lruihao Lruihao reopened this Nov 19, 2022
Roadmap automation moved this from Done to In progress Nov 19, 2022
@Lruihao
Copy link
Member

Lruihao commented Nov 19, 2022

resolved

@Lruihao Lruihao closed this as completed Nov 19, 2022
Roadmap automation moved this from In progress to Done Nov 19, 2022
@Kapusch
Copy link
Contributor Author

Kapusch commented Nov 20, 2022

Hi @Lruihao , thank you for your quick fix !
I just gave a try and now the hashtag character is well escaped.

However, I wonder if I should do something else regarding the commas that have disappear, or is it a side-effect bug ?
image

As a reminder, here is my front matter property:
Tags: ["C# markup","Grid"]

@Lruihao
Copy link
Member

Lruihao commented Nov 20, 2022

However, I wonder if I should do something else regarding the commas that have disappear, or is it a side-effect bug ?

@Kapusch This is not a bug because your local browser caches old css style. Clear the browser cache, it will be okay.

Press F12, select style.min.css and click clear browser cache.

截屏2022-11-20 18 49 39

@Kapusch
Copy link
Contributor Author

Kapusch commented Nov 20, 2022

Thanks for your help, I thought I already cleared it, so maybe it's after I relaunched the website with Hugo serve command.
It's all good now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Roadmap
  
Done
Development

No branches or pull requests

2 participants