-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme via DarkReader #595
Conversation
…guerres/toha into dev-configure-recent-posts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @donfiguerres, Thank you for the amazing work. I have added few comments. Can you please acknowledge them. Otherwise, looks good to me.
Thanks for the feedback! I agree with your inputs. I'll work on these and push the changes to my branch. |
…into dev-dark-theme
Done with the changes and already live on my website at https://donfiguerres.com/ if you need to see how it looks. I also did a quick test with the multilingual mode to make sure it doesn't conflict with the language dropdown menu. |
Hi @donfiguerres, thanks again for the hard work. Looks good to me. I will test and merge soon. |
Issue
Closes #59
Description
Use DarkReader as a darkmode provider.
I've added the option to use other theme color providers and hopefully toha's own dark theme in the future. This possible with the darkTheme.provider property. Below is an example on how to set-up the dark theme. I'm also planning to add this information to the toha documentation.
The drawback of this is that it is a lot slower than having your own dark theme because the theme is dynamically generated.
Test Evidence
It's already live in my website https://donfiguerres.com/
![image](https://user-images.githubusercontent.com/12525903/171840303-dbe78c22-b4c6-4e76-b043-d928b33fbebc.png)
![image](https://user-images.githubusercontent.com/12525903/171840445-6a761f3f-06cf-4d87-9ce4-2d090651d3ff.png)