Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Plugin load order in 4.25 from source #53

Closed
Altrue opened this issue Dec 27, 2020 · 12 comments
Closed

Issue with Plugin load order in 4.25 from source #53

Altrue opened this issue Dec 27, 2020 · 12 comments
Assignees
Labels
bug Something isn't working pending Pending approval ready Issue is fixed and ready to be deployed
Milestone

Comments

@Altrue
Copy link

Altrue commented Dec 27, 2020

Hi,

Just wanted to report that the plugin didn't seem to work very well for me on my 4.25 UE4 built from source.

After comparing it with the launcher's 4.25, and doing some debugging on the plugin, it seems like the content in Editor/EditorStyle/ was being called AFTER Plugins/DarkerNodes/Source/DarkerNodes/, and as is to be expected, undid most of the changes from DarkerNodes.

In DarkerNodes.uplugin, I changed the "LoadingPhase" from "Default" to "PostEngineInit", which has solved the issue for me. It may be a good idea to incorporate this change into the official plugin :)

@Altrue
Copy link
Author

Altrue commented Dec 27, 2020

I'm using a source build in order to be able to build dedicated servers. I haven't changed the engine code, so I don't believe there's anything that might impact the plugin load order on my end.

@GoVRCenter
Copy link

I am also using a source build of 4.25 and I am not experiencing this issue. Mine is installed to /Engine/Plugins/Marketplace, maybe that makes a difference?

@hugoattal
Copy link
Owner

That's weird 🤔... I don't know yet if I'll change the loading phase or if I'll add this to the doc for other people encountering this problem... I'll see what impact a PostEngineInit loading phase can have.

@Altrue
Copy link
Author

Altrue commented Dec 29, 2020

Maybe it's a weird legacy thing that I have going on, or maybe by recompiling the full engine it'll go away. I tried installing it in Engine/Plugins/Marketplace too.

Anyway, if the issue is not widespread among source users then it seems like a line in the doc might be a better solution?

Most of my UI is done in Slate. Maybe the inclusion of "Slate" and "SlateCore" in my build.cs (along with "UnrealEd" and "UMG") is the cause of this.

@Theliraan
Copy link

Have same problem with 4.25.4 from Launcher. But everything is ok on 4.26.0

@hugoattal
Copy link
Owner

@Theliraan That's weird, I'll change the loading phase then... Could you c/c your log of engine start just out of curiosity?

@hugoattal hugoattal added the bug Something isn't working label Jan 5, 2021
@Theliraan
Copy link

@Theliraan That's weird, I'll change the loading phase then... Could you c/c your log of engine start just out of curiosity?

It's more interest situation: I can reproduce bug on 4.25.4 only when opening editor from IDE (Development Editor | Win64 | Rider 2020.3.3 | VSCode latest) and only in one project. So my icons are old here and blueprint nodes aren't flat.

Using plugin on engine.

WORKS GOOD - 4.25.4 - From launcher - BP Project A.log
WORKS GOOD - 4.26.0 - From launcher - BP Project A.log

WORKS BAD - 4.25.4 - From IDE - CPP Project B.log

WORKS GOOD - 4.25.4 - From IDE - CPP Project C.log
WORKS GOOD - 4.25.4 - From launcher - CPP Project C.log
WORKS GOOD - 4.26.0 - From IDE - CPP Project C.log
WORKS GOOD - 4.26.0 - From launcher - CPP Project C.log

@hugoattal
Copy link
Owner

Maybe something overwrite DarkerNodes modification by resetting the style of the editor, but I find it really weird...

If it were a plugin, it will be among those:

LogPluginManager: Mounting plugin ApexDestruction
LogPluginManager: Mounting plugin GameplayAbilities
LogPluginManager: Mounting plugin EasyMultiSave
LogPluginManager: Mounting plugin ElectronicNodes
LogPluginManager: Mounting plugin FMODStudio
LogPluginManager: Mounting plugin LDAssistant
LogPluginManager: Mounting plugin LogViewerPro
LogPluginManager: Mounting plugin Substance

But I don't think so... Changing the LoadingPhase to PostEngineInit does solve the problem? If it is, I'll just update this on the next version 😉

@hugoattal
Copy link
Owner

hugoattal commented Jan 6, 2021

And just to be sure, you do have the 1.6 version of Darker Nodes?

@Theliraan
Copy link

And just to be sure, you do have the 1.6 version of Darker Nodes?

Yes, it's 1.6. Changing LoadingPhase from Default to PostEngineInit helps, thanks so much. Do I need provide some additional information?

@hugoattal
Copy link
Owner

@Theliraan That would be awesome if you could try with PostDefault too! I'd prefer that option over PostEngineInit.

@Theliraan
Copy link

Theliraan commented Jan 6, 2021

@Theliraan That would be awesome if you could try with PostDefault too! I'd prefer that option over PostEngineInit.

PostDefault also works as correct as PostEngineInit. Screenshots with Default vs PostDefault:

image
image

@hugoattal hugoattal added the ready Issue is fixed and ready to be deployed label Jan 6, 2021
@hugoattal hugoattal added this to the 1.7 milestone Jan 6, 2021
@hugoattal hugoattal self-assigned this Jan 7, 2021
@hugoattal hugoattal added the pending Pending approval label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending Pending approval ready Issue is fixed and ready to be deployed
Projects
None yet
Development

No branches or pull requests

4 participants