Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return types from vfuncs are not converted #34

Closed
BlobCodes opened this issue Jun 17, 2022 · 1 comment · Fixed by #60
Closed

Return types from vfuncs are not converted #34

BlobCodes opened this issue Jun 17, 2022 · 1 comment · Fixed by #60
Assignees
Labels
bug Something isn't working
Milestone

Comments

@BlobCodes
Copy link
Contributor

(yes this is my fault)

Currently, return values from vfuncs implemented by GObject subclasses are not converted.
For example, if I want to implement the vfunc get_request_mode, I would normally assume I have to return a Gtk::SizeRequestMode. However, the current implementation wants me to return a UInt32.

I think we can copy the code used for conversion to c-types from the signal implementation (which is what I did for the vfunc parameters as well).

@BlobCodes BlobCodes changed the title Outputs from vfuncs are not converted Return types from vfuncs are not converted Jun 17, 2022
@hugopl hugopl added the bug Something isn't working label Jun 20, 2022
@hugopl hugopl added this to the v0.14.0 milestone Jul 8, 2022
@hugopl hugopl self-assigned this Jul 8, 2022
@hugopl
Copy link
Owner

hugopl commented Jul 8, 2022

BTW, this isn't your fault at all, the vfuncs implementation is great and it doesn't need to be 100% functional and bug free from day 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants