Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert setup.py to static setup.cfg #82

Merged
merged 3 commits into from
May 7, 2021
Merged

Convert setup.py to static setup.cfg #82

merged 3 commits into from
May 7, 2021

Conversation

hugovk
Copy link
Owner

@hugovk hugovk commented May 7, 2021

Converted using https://github.com/asottile/setup-py-upgrade. First this happened:

$ setup-py-upgrade .
use_scm_version= is not supported in setup.cfg

So temporarily removed that line from setup.py and re-ran it:

$ setup-py-upgrade .
./setup.py and ./setup.cfg written!

Then reinstated use_scm_version= and local_scheme(version) in setup.py.


Also add https://github.com/asottile/setup-cfg-fmt to pre-commit and autoupdate.

@hugovk hugovk added the changelog: Changed For changes in existing functionality label May 7, 2021
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #82 (b68b093) into master (ac1ec81) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #82   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           13        13           
=========================================
  Hits            13        13           
Flag Coverage Δ
GHA_Ubuntu1604 100.00% <ø> (ø)
GHA_Ubuntu1804 100.00% <ø> (ø)
GHA_Ubuntu2004 100.00% <ø> (ø)
GHA_macOS 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac1ec81...b68b093. Read the comment docs.

@hugovk hugovk enabled auto-merge May 7, 2021 19:34
@hugovk hugovk merged commit 2d3bfb7 into master May 7, 2021
@hugovk hugovk deleted the setup-py-upgrade branch May 7, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Changed For changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant