hexdump and dereference start dumping from offset #398
Comments
|
Confirmed |
… command typed to trigger to auto-continuation
|
After 8deeafb |
|
@elklepo Please check and let us know. |
|
@hugsy Thank You very much. I can confirm that it works properly. |
|
Happy to read that. |
That doesn't look right, if you run |
gdb 8.2 this is the issue I think, see https://sourceware.org/bugzilla/show_bug.cgi?id=23714 and https://sourceware.org/bugzilla/show_bug.cgi?id=23669 |
So it seems that if You follow one command by exact same command it dumps memory sequentially and applied offset is reset once different command is executed, in my opinion it is good behavior (for sure it is not an issue but a personal preference). The thing that is a problem, is that the |
Yeah this is what is meant to happen if you press But if you retype the same command then it should use the exact arguments. After 8deeafb the offset will never be reset: |
^ is what is currently broken in gdb 8.2 but will be fixed in 8.2.1 (see #398 (comment)). I've looked into a few workarounds but the combination of both of those bugs makes it really hard. cyrus-and/gdb-dashboard#128 is the same issue |
|
Thank you for the explanation, it makes sense. |
|
Agreed, the patch is still in |
Is the anyway we can check if they are using gdb 8.2? The patch is a good work around for 8.2 but makes things worse on all other versions. Even when gdb fixes it 8.2 will always have the issue so might still need the workaround :( |
|
Yeah, I don't like the fix. @wbowling |
|
@wbowling Do you think it's simply better to revert the fix and wait for 8.2.1 ? I really don't mind doing that, but I kindda think that starting to test for specific versions of GDB for features is a slippery slope. |
No worries, I'll do that. |
|
I would rather revert the fix. The fix makes it worse, and it gets rid of one of the better features we added in the last release. Add a note and maybe config that lets people disable it. |
Yeah I agree it’s probably not something we want to start doing, maybe just a warning on startup or a way to disable it. |
|
@wbowling Any idea on when 8.2.1 is due for release ? I mean, I don't the point in spending too much effort on our side if it's coming out soon, since it's a GDB issue. |
It's a bit hard to tell from https://www.gnu.org/software/gdb/schedule/ but looks like 8.3 is scheduled for |
… last command typed to trigger to auto-continuation
|
Gdb 8.2.1 is released https://www.gnu.org/software/gdb/download/ANNOUNCEMENT |
|
What's the AI on this? This works for me on dev. What did the workaround break? |
|
There’s no way to tell if it’s a repeat command from an |
|
With 8.2.1 (any version except 8.2) it shouldn’t be needed |
|
That's not the case for me. |
|
I think it was reverted? |
|
I seem to have the delta in dev. I don't care much, I just want to know if something has to be fixed or if we should close the ticket :) |
|
Cleanup |
Your issue will be closed unless you confirm the following:
masterbranch?Step 1: Describe your environment
Step 2: Describe your problem
hexdumpanddereferencedo not print dump of exact address but they apply offset to it that increments after every single call, e.g.This offset is also applied to
hexdumpanddereferencecalls to other address/register targets.Steps to reproduce
Observed Results
Expected results
hexdumpanddereferenceprint dump of exact address that is passed as argument.Traces
Another example:
The text was updated successfully, but these errors were encountered: