Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate some classes to rely on PCustom structures #778

Closed
2 tasks
hugsy opened this issue Jan 11, 2022 · 0 comments
Closed
2 tasks

Migrate some classes to rely on PCustom structures #778

hugsy opened this issue Jan 11, 2022 · 0 comments
Labels
code-quality enhancement

Comments

@hugsy
Copy link
Owner

hugsy commented Jan 11, 2022

TODO:

  • MallocStateStruct
    • gef-extras/structs/struct malloc_state
hugsy pushed a commit that referenced this issue Jan 18, 2022
Entirely rewrote the pcustom functionality to make it usable from o…
f8aecd7 
…ther plugins (see #778)
@hugsy hugsy mentioned this issue Jan 18, 2022
Merged
5 tasks
hugsy added a commit that referenced this issue Jan 25, 2022
@hugsy @Grazfather @theguy147
Complete rewrite of pcustom command (#794)
779369f 
* Entirely rewrote the `pcustom` functionality to make it usable from other plugins (see #778)

* - applied PR comments
 - added cache

* Apply suggestions from @Grazfather

Co-authored-by: Grazfather <grazfather@gmail.com>

* Changed signature of `apply_at`

* Revert "Apply suggestions from @Grazfather"

This reverts commit 3948328.

* linting + formatting

* last fix

* making `Modules` and `Module` inherit `dict` so we can use getitem and iteration from it

* removed unused var in `PCustomListCommand`

* Apply suggestions from code review

Co-authored-by: theguy147 <37738506+theguy147@users.noreply.github.com>

* - added error message in `pcustom show` when not found
- passing a reference to `ExternalStructureLoader` to modules and structures for nested structure to work properly

* - added `pcustom list` test

* - added test for `pcustom show` with and without address

* Update gef.py

Co-authored-by: Grazfather <grazfather@gmail.com>

* - `pcustom` prints error message if struct name not found
- added CI tests  for error messages

Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: theguy147 <37738506+theguy147@users.noreply.github.com>
@hugsy hugsy closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hugsy