Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: complete type hints for py3.6 before release #787

Closed
theguy147 opened this issue Jan 15, 2022 · 1 comment · Fixed by #797
Closed

feature: complete type hints for py3.6 before release #787

theguy147 opened this issue Jan 15, 2022 · 1 comment · Fixed by #797
Assignees
@theguy147
Labels
enhancement new feature
Milestone
Release: 2022.01

Comments

@theguy147
Copy link
Collaborator

As the title says, before the next release the newly introduced type hints should be completed. This issue should be considered a reminder for this.
@theguy147 theguy147 added this to the Release: next milestone Jan 15, 2022
@theguy147 theguy147 self-assigned this Jan 15, 2022
@Grazfather
Copy link
Collaborator

*args doesn't work as you think: It's a tuple, but the type hint is for the type of args, so if they are mixed, the type would be Any. if they are all strings, then the hint should be str NOT Tuple[str, ...] as you might expect.

@theguy147 theguy147 mentioned this issue Jan 18, 2022
Merged
5 tasks
@theguy147 theguy147 linked a pull request Jan 18, 2022 that will close this issue
refactor: add missing py3.6 type hints #797
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theguy147 theguy147

Labels
enhancement new feature
Projects
None yet
Milestone
Release: 2022.01
Development

Successfully merging a pull request may close this issue.

refactor: add missing py3.6 type hints theguy147/gef
2 participants
@Grazfather @theguy147