refactor: add missing py3.6 type hints #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugsy
requested changes
Jan 19, 2022
Co-authored-by: hugsy <hugsy@users.noreply.github.com>
Grazfather
reviewed
Jan 19, 2022
gef.py
Outdated
| try: | ||
| arena = gdb.parse_and_eval(addr) | ||
| malloc_state_t = cached_lookup_type("struct malloc_state") | ||
| self.__arena = arena.cast(malloc_state_t) | ||
| self.__arena = arena.cast(malloc_state_t) # "gdb.Value" |
There was a problem hiding this comment.
We can't do self.__arena : "gdb.Value" = ...?
There was a problem hiding this comment.
actually that is a comment for understanding the code better. I put it there to emphasize it for the reader because actually what we do is highly problematic (to sometimes have the arena be a gdb.Value and sometimes a MallocStateStruct with different ways of handling them)
There was a problem hiding this comment.
its actually not a type hint. the type hint is a few lines above that.
There was a problem hiding this comment.
Ah. Let's reword it with basically what you just said?
There was a problem hiding this comment.
is this better now? please resolve if you agree
hugsy
approved these changes
Jan 19, 2022
Grazfather
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing type hints (py3.6)
Description/Motivation/Screenshots
This PR adds still missing type hints to
gef.py(Issue #787).Also a few very minor type hint related issues have been fixed (e.g. removing
return <expression>where expression always evaluates toNone)EDIT:
The PR also removes a few unnecessary function/method arguments
How Has This Been Tested?
make testChecklist
devbranch, notmaster.