Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch coverage to non-blocking github comment #937

Closed
hugsy opened this issue Mar 19, 2023 · 0 comments · Fixed by #938
Closed

Switch coverage to non-blocking github comment #937

hugsy opened this issue Mar 19, 2023 · 0 comments · Fixed by #938
Assignees
@hugsy
Labels
automation/ci code-quality

Comments

@hugsy
Copy link
Owner

hugsy commented Mar 19, 2023

Type of feature request

Misc

Misc

CI

Summary Description

It's not a good idea to fail on CI when coverage decreases.
Switch coverage to sending a Github comment instead so we know about it during the review process, but doesn't impact the validation status.

Implementation idea/suggestion

Switch coverage to sending a Github comment instead so we know about it during the review process, but doesn't impact the validation status.

Existing alternatives?

No response

Additional information

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hugsy hugsy

Labels
automation/ci code-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] Make coverage generate pull request comment instead of blocking validation hugsy/gef
1 participant
@hugsy