Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Make coverage generate pull request comment instead of blocking validation #938

Merged
merged 3 commits into from Apr 16, 2023

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Mar 20, 2023

Description/Motivation/Screenshots

Move coverage to separate job on CI, to only send coverage results as comment to the PR (instead of failing it if lower).

This will give us a per-commit improvement for the PR. Based on that info, we can then decide to approve or reject if the drop is too high. This is less aggressive that failing the CI tests.

Against which architecture was this tested ?

N/A (CI only)

Checklist

  • My PR was done against the dev branch, not main.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

Repository owner deleted a comment from github-actions bot Apr 15, 2023
Repository owner deleted a comment from github-actions bot Apr 15, 2023
@github-actions
Copy link

🤖 Coverage Update

  • Commit: e5ff08e
  • Current Coverage: 71.3331%
  • New Coverage: 71.3331%
  • Diff: 0.0

@hugsy hugsy changed the title [ci] moved coverage to dedicated file [CI] Make coverage generate pull request comment instead of blocking validation Apr 16, 2023
@github-actions
Copy link

🤖 Coverage Update

  • Commit: 09273b9
  • Current Coverage: 71.3331%
  • New Coverage: 71.3331%
  • Diff: 0.0

@hugsy hugsy marked this pull request as ready for review April 16, 2023 00:16
Repository owner deleted a comment from github-actions bot Apr 16, 2023
@hugsy hugsy linked an issue Apr 16, 2023 that may be closed by this pull request
@hugsy hugsy merged commit b1a1b2a into dev Apr 16, 2023
4 checks passed
@hugsy hugsy deleted the hugsy/issue937 branch April 16, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch coverage to non-blocking github comment
1 participant