Let GefSetting write hooks see value #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
force-pushed
the
gefsetting_write_validators
branch
2 times, most recently
from
db08871
to
f58ed9a
Compare
Grazfather
force-pushed
the
gefsetting_write_validators
branch
from
f58ed9a
to
f0b6ae5
Compare
🤖 Coverage Update
To this point, this PR:
|
|
💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 |
🤖 Coverage Update
To this point, this PR:
|
🤖 Coverage Update
To this point, this PR:
|
🤖 Coverage Update
To this point, this PR:
|
🤖 Coverage Update
To this point, this PR:
|
🤖 Coverage Update
To this point, this PR:
|
🤖 Coverage Update
To this point, this PR:
|
hugsy
approved these changes
Aug 26, 2023
12 tasks
hugsy
added a commit
to hugsy/gef-extras
that referenced
this pull request
Oct 19, 2023
…nt (#94) hugsy/gef#1000 introduced a callback signature change for `on-write` hooks, which broke `capstone.py` (reported [on discord](https://discord.com/channels/705160148813086841/705160148813086843/1164321916404891729)). This PR fixes that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes it so that write hooks see the actual value provided to a setting when
gef configis used, and gives it the chance to raise an exception if the value is invalid.It also adds a validator 'no_spaces' and adds it to a few settings that use filepaths, since we know (from #999) that some GDB commands completely break when paths have spaces and/or when paths are quotes.
Checklist