Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not quote paths when running 'source' #1005

Merged
merged 1 commit into from Sep 12, 2023
Merged

Do not quote paths when running 'source' #1005

merged 1 commit into from Sep 12, 2023

Conversation

Grazfather
Copy link
Collaborator

@Grazfather Grazfather commented Sep 11, 2023

Description

gdb's source doesn't understand quotes. Annoying.

We should be OK not quoting it since the config has a hook to ensure the path doesn't have spaces.

Discovered by @southball

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@github-actions
Copy link

🤖 Coverage Update

  • Commit: 1247fe4
  • Current Coverage: 71.6387%
  • New Coverage: 71.6387%
  • Diff: 0.0

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation
  • does not include forbidden words

@github-actions
Copy link

🤖 Coverage Update

  • Commit: 0e315d0
  • Current Coverage: 71.6387%
  • New Coverage: 71.6387%
  • Diff: 0.0

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation
  • does not include forbidden words

@hugsy hugsy merged commit 5927df4 into main Sep 12, 2023
7 checks passed
@hugsy hugsy deleted the fix_source_quoting branch September 12, 2023 03:34
@hugsy hugsy added this to the 2024.01 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants