Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage workflow should only be triggered by pull_request #1023

Merged
merged 3 commits into from Dec 16, 2023
Merged

Coverage workflow should only be triggered by pull_request #1023

merged 3 commits into from Dec 16, 2023

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Dec 16, 2023 •
edited

Description

Coverage workflow should only be triggered by pull_request.
In addition, even if it worked, that would post twice the exact same message (once from pull_request, another from pull_request_target).

Error example to avoid:

image

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@hugsy hugsy marked this pull request as draft December 16, 2023 01:21
@hugsy hugsy changed the title Coverage workflow should only be triggered by pull_request_target Coverage workflow should only be triggered by pull_request Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
Repository owner deleted a comment from github-actions bot Dec 16, 2023
@hugsy hugsy force-pushed the fix_ci_coverage_report_error branch from 82425e4 to e6084a3 Compare December 16, 2023 18:42
Repository owner deleted a comment from github-actions bot Dec 16, 2023
@hugsy hugsy marked this pull request as ready for review December 16, 2023 18:42
@github-actions GitHub Actions
Copy link

🤖 Coverage update for e6084a3

  • Diff Commit: f7a2105..e6084a3
  • Current vs New Coverage Score: 71.4511% / 71.4511%
  • Difference: 0.0 🟢

To this point, this PR:

  • includes changes to tests
  • includes changes to documentation
  • does not include forbidden words

@github-actions GitHub Actions
Copy link

🤖 Coverage Update

  • Commit: f7a2105
  • Current Coverage: 71.4511%
  • New Coverage: 71.4511%
  • Diff: 0.0

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation
  • does not include forbidden words

@github-actions GitHub Actions
Copy link

🤖 Coverage update for adaf627

  • Diff Commit: f7a2105..adaf627
  • Current vs New Coverage Score: 71.4511% / 71.4511%
  • Difference: 0.0 🟢

To this point, this PR:

  • includes changes to tests
  • includes changes to documentation
  • does not include forbidden words

@github-actions GitHub Actions
Copy link

🤖 Coverage Update

  • Commit: f7a2105
  • Current Coverage: 71.4511%
  • New Coverage: 71.4511%
  • Diff: 0.0

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation
  • does not include forbidden words

theguy147
theguy147 approved these changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@theguy147 theguy147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hugsy

This comment was marked as resolved.

Sign in to view

@github-actions GitHub Actions
Copy link

🤖 Coverage Update

  • Commit: f7a2105
  • Current Coverage: 71.4511%
  • New Coverage: 71.4511%
  • Diff: 0.0

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation
  • does not include forbidden words

@github-actions GitHub Actions
Copy link

🤖 Coverage update for 996bcf3

  • Diff Commit: f7a2105..996bcf3
  • Current vs New Coverage Score: 71.4511% / 71.4511%
  • Difference: 0.0 🟢

To this point, this PR:

  • includes changes to tests
  • includes changes to documentation
  • does not include forbidden words

@Grazfather Grazfather merged commit 0eb7f5c into main Dec 16, 2023
6 checks passed
@Grazfather Grazfather deleted the fix_ci_coverage_report_error branch December 16, 2023 22:56
@hugsy hugsy added this to the 2024.01 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grazfather Grazfather Grazfather approved these changes

@theguy147 theguy147 theguy147 approved these changes

@daniellimws daniellimws Awaiting requested review from daniellimws

@therealdreg therealdreg Awaiting requested review from therealdreg

Assignees
No one assigned
Labels
automation/ci bug documentation
Projects
None yet
Milestone
2024.01
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hugsy @Grazfather @theguy147