Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a source post hook #1059

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Add a source post hook #1059

merged 2 commits into from
Feb 1, 2024

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Jan 26, 2024

Description

Add a post hook to source to automatically reload gef commands and move @register-ed new commands to being active.

TODO: figure out when posthook appeared for compat

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

Copy link

🤖 Coverage update for 48a79dd 🟢

Old New
Commit 13a9339 48a79dd
Score 71.565% 71.565% (0)

Copy link

🤖 Coverage update for 48a79dd 🟢

Old New
Commit 13a9339 48a79dd
Score 71.565% 71.5705% (0.0055)

@Grazfather
Copy link
Collaborator

This (somehow) breaks my hugsy/gef-extras#99

Copy link
Collaborator

@Grazfather Grazfather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind! It's because this change was missing #1056

gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
Copy link

🤖 Coverage update for eb2f6cc 🔴

Old New
Commit 13a9339 eb2f6cc
Score 71.5816% 71.565% (-0.0166)

Copy link

🤖 Coverage update for eb2f6cc 🔴

Old New
Commit 13a9339 eb2f6cc
Score 71.5816% 71.5623% (-0.0193)

@hugsy hugsy merged commit 4c307e6 into main Feb 1, 2024
6 checks passed
@hugsy hugsy deleted the add_source_post_hook branch February 1, 2024 01:51
@hugsy hugsy added this to the 2024.05 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants