Add pl and mi conditional codes #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we have a few flags wrong: ge, gt, lt, lte. Could you please fix them all? |
|
They aren't actually wrong, they just called overflow O when it's usually called V. I'll fix it. |
Grazfather
reviewed
Oct 17, 2018
| elif mnemo.endswith("mi"): | ||
| taken, reason = val&(1<<flags["negative"]), "N" | ||
| elif mnemo.endswith("pl"): | ||
| taken, reason = not val&(1<<flags["negative"]), "N==O" |
There was a problem hiding this comment.
You mean N==0, not N==O. Plus we have been putting !Z, so we should be consistent.
|
Take a look at #360, I think this knocks them all out. Care to test? |
|
Look at #361. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
plandmiconditional codes to Aarch64 branch logicHow Has This Been Tested?
make tests