Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better GEF Aliases Functionality #640

Merged
merged 10 commits into from Jun 9, 2021
Merged

Better GEF Aliases Functionality #640

merged 10 commits into from Jun 9, 2021

Conversation

hoefler02
Copy link
Contributor

Better GEF Aliases Functionality

Description/Motivation/Screenshots

Adds better functionality to the aliases command. This closes Issue #636. Examples below.

Adding an alias... (command can contain spaces)

aliases add [alias] [command]

Removing an alias...

aliases rm [alias]

Listing aliases...

aliases list

Any aliases added will be automatically added to the ~/.gef.rc file, and the removed aliases will be removed. I have also updated the docs with the new usage of the command.

How Has This Been Tested?

I have tested this patch across several machines running Debian and Arch based distros.

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to change.
Also this new feature could use some unit tests.

But nice work.

gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
docs/commands/aliases.md Outdated Show resolved Hide resolved
gef.py Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
tests/runtests.py Outdated Show resolved Hide resolved
@hugsy
Copy link
Owner

hugsy commented May 28, 2021

Ping?
The PR is almost complete, any chance it could be finished soon?

@hoefler02
Copy link
Contributor Author

Yeah I'm finally done with school so this should be done within the next few days. Sorry for the inactivity!

Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change, and it'll be 👍

gef.py Outdated Show resolved Hide resolved
@hugsy hugsy self-assigned this Jun 6, 2021
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
tests/runtests.py Show resolved Hide resolved
@hugsy hugsy merged commit 9308054 into hugsy:dev Jun 9, 2021
@hugsy
Copy link
Owner

hugsy commented Jun 9, 2021

Great job @hoefler02 !

@hugsy hugsy added this to the 2021-07 Release milestone Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants