Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aarch64 tbz, tbnz, cbz and cbnz instructions estimation #656

Merged
merged 1 commit into from Jun 5, 2021

Conversation

borismol
Copy link
Contributor

@borismol borismol commented Jun 5, 2021

Fix aarch64 tbz, tbnz, cbz and cbnz instructions estimation

Description/Motivation/Screenshots

Fix failure [!] Command 'context' failed to execute properly, reason: while estimating aarch64 test/compare and branch instructions.
branch_fix

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✖️
x86-64 ✖️
ARM ✖️
AARCH64 ✔️ tbz, tbnz, cbz and cbnz branches are correctly estimated
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make tests ✔️

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • [] My change includes a change to the documentation, if required.
  • [] My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

@hugsy hugsy self-assigned this Jun 5, 2021
gef.py Outdated Show resolved Hide resolved
@borismol borismol force-pushed the fix-aarch64-test-and-branch branch from 9f30fea to c032bf6 Compare June 5, 2021 19:02
@borismol borismol requested a review from hugsy June 5, 2021 19:10
gef.py Show resolved Hide resolved
@hugsy hugsy merged commit 1b77c62 into hugsy:dev Jun 5, 2021
@hugsy hugsy added this to the 2021-07 Release milestone Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants