Remove more python2-specific stuff #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the point of this PR ? Tests are not even passing |
|
I don't think this PR is necessary anymore, I think most points were fixed by ee81a62 |
Grazfather
force-pushed
the
remove_more_python2
branch
from
5df3002
to
c18a28a
Compare
|
I rebased. It still fixes things like some useless imports and makes the style more consistent. |
Grazfather
force-pushed
the
remove_more_python2
branch
4 times, most recently
from
efa85f4
to
0a72e24
Compare
Grazfather
commented
Jul 3, 2021
Grazfather
force-pushed
the
remove_more_python2
branch
from
0a72e24
to
41f6213
Compare
daniellimws
reviewed
Jul 3, 2021
Grazfather
force-pushed
the
remove_more_python2
branch
3 times, most recently
from
7f58147
to
f818ed9
Compare
hugsy
requested changes
Jul 3, 2021
Grazfather
force-pushed
the
remove_more_python2
branch
from
f818ed9
to
22be572
Compare
Grazfather
force-pushed
the
remove_more_python2
branch
from
22be572
to
023870f
Compare
Grazfather
force-pushed
the
remove_more_python2
branch
3 times, most recently
from
9b3375f
to
9984a42
Compare
Cache was being used, but we were only caching the .wheel files. We still need to `pip install` in order to use the cache.
Grazfather
force-pushed
the
remove_more_python2
branch
from
9984a42
to
41bbec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ran 2-to-3 on it.