Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context registers order #670

Merged
merged 1 commit into from Jun 28, 2021
Merged

Conversation

borismol
Copy link
Contributor

Fix context registers order

Description/Motivation/Screenshots

Context registers order was broken
regs_disorder
Now it is fixed
regs_order

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✖️
x86-64 ✖️
ARM ✖️
AARCH64 ✔️
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make tests ✔️

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • [] My change includes a change to the documentation, if required.
  • [] My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

@Grazfather
Copy link
Collaborator

Easy! Looks good.

@hugsy
Copy link
Owner

hugsy commented Jun 28, 2021

Ah good catch! I didn't realize it when I moved registers to use parse_arguments... 🤦‍♂️

@Grazfather Grazfather merged commit cdb4896 into hugsy:dev Jun 28, 2021
hugsy pushed a commit that referenced this pull request Jul 1, 2021
hugsy pushed a commit that referenced this pull request Jul 1, 2021
@hugsy hugsy added this to the Release 2021.07 milestone Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants