refactor: use parse_address whenever appropriate

[theguy147]

refactor: use parse_address whenever appropriate

Description/Motivation/Screenshots

This small refactoring PR replaces the following occurrences with parse_address for consistency and easier maintainability:

• to_unsigned_long(gdb.parse_and_eval(...))
• int(gdb.parse_and_eval(...))

How Has This Been Tested?

Architecture	Yes/No	Comments
x86-32	✔️
x86-64	✔️
ARM	✖️
AARCH64	✖️
MIPS	✖️
POWERPC	✖️
SPARC	✖️
RISC-V	✖️
make test	✔️

Checklist

• My PR was done against the dev branch, not master.
• My code follows the code style of this project.
• My change includes a change to the documentation, if required.
• My change adds tests as appropriate.
• I have read and agree to the CONTRIBUTING document.

[theguy147]

the only place of them I am actually not a 100% sure if it's a good idea changing int(gdb.parse_and_eval(...)) to parse_address(...) is in __get_register_for_selected_frame (and thereby get_register).

EDIT:
nevermind. with get_register there should never be a difference between converting it to int or unsigned_long. the calling function should always use something like long_to_twos_complement in RISCV class or similar if negative values are to be expected.

[hugsy]

Woohoo Ctrl+H FTW

[Grazfather]

Nice work :)

I like changes like this, but they are also scary. I hope you're able to at least test each command that would be affected by these changes.

[theguy147]

Nice work :)

I like changes like this, but they are also scary. I hope you're able to at least test each command that would be affected by these changes.

Apart from some usages of get_register (total of 46 usages across gef.py - I tested around half of them) I have checked all commands, functions and structs manually on a x86_64 machine and didn't get any errors and the tests are running successfully. I also didn't test ida-interact because I don't have IDA or Binja installed on this machine. I can check it out in a few days when I'm back home from traveling.

[hugsy]

I also didn't test ida-interact because I don't have IDA or Binja installed on this machine. I can check it out in a few days when I'm back home from traveling.

Don't bother, ida-interact is being moved to gef-extras