Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sha256 for gef_hash to quiet static analyzers #751

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

mattadev
Copy link
Contributor

Use sha256 for gef_hash to quiet static analyzers

Description/Motivation/Screenshots

Switches to using hashlib.sha256 instead of hashlib.sha1 for the gef_hash.
This is primarily to quiet static analyzers that complain about the use of SHA1.

How Has This Been Tested?

Architecture Yes/No Comments
x86-64 ✔️

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straight forward, lgtm

@hugsy hugsy merged commit 721ad4b into hugsy:dev Nov 16, 2021
@hugsy hugsy added this to the Release: 2022.01 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants