Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds constants to gef.py for M68K support (in gef-extras) #757

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Adds constants to gef.py for M68K support (in gef-extras) #757

merged 1 commit into from
Dec 6, 2021

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Nov 26, 2021

Description

Trivial PR to add the constants for M68K to gef so it can be sourced from https://github.com/hugsy/gef-extras/blob/master/archs/m68k.py

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✔️
x86-64 ✔️
ARM ✖️
AARCH64 ✖️
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make test ✔️

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

@hugsy hugsy added this to the Release: next milestone Nov 26, 2021
theguy147
theguy147 approved these changes Nov 27, 2021
View reviewed changes
Copy link
Collaborator

@theguy147 theguy147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugsy hugsy merged commit 3efb77b into dev Dec 6, 2021
@hugsy hugsy deleted the add_missing_constants_for_m68k branch December 6, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellimws daniellimws daniellimws approved these changes

@theguy147 theguy147 theguy147 approved these changes

@Grazfather Grazfather Awaiting requested review from Grazfather

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release: 2022.01
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hugsy @daniellimws @theguy147