add support for hex strings to print-format #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugsy
requested changes
Nov 27, 2021
…upport Co-authored-by: hugsy <hugsy@users.noreply.github.com>
hugsy
approved these changes
Nov 28, 2021
Grazfather
reviewed
Nov 29, 2021
Grazfather
requested changes
Nov 29, 2021
…o columns are padded correctly
|
using hexlify like this also is better bc it means the endianness is correct for bit lengths of not 8 |
Grazfather
reviewed
Nov 29, 2021
Grazfather
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for hex strings to print-format
Description/Motivation/Screenshots
This patch adds an additional format to the command
print-format-- a hex string like "00112233" instead of [0x00, 0x11, 0x22, 0x33]. I end up printing memory in another format and manually adjusting it often enough to be worth writing the code for me and I thought it was generally useful enough to PR back. I also adjusted phrasing in the documentation a little bit to signify that print format can output memory in a number of different formats, only some of which are byte array literals.How Has This Been Tested?
make testChecklist
devbranch, notmaster.