@deprecated warning display can be toggled off
#795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
approved these changes
Jan 18, 2022
gef.py
Outdated
| @@ -10480,6 +10481,7 @@ def __init__(self) -> None: | |||
| gef.config["gef.extra_plugins_dir"] = GefSetting("", str, "Autoload additional GEF commands from external directory") | |||
| gef.config["gef.disable_color"] = GefSetting(False, bool, "Disable all colors in GEF") | |||
| gef.config["gef.tempdir"] = GefSetting(GEF_TEMP_DIR, str, "Directory to use for temporary/cache content") | |||
| gef.config["gef.show_deprecated_warnings"] = GefSetting(True, bool, "Toggle the display of the `deprecated` warnings") | |||
There was a problem hiding this comment.
Might want to reconsider the name 'show_deprecated_warnings' sounds like the warnings are deprecated, not that the warnings are about deprecation. Maybe we show_deprecation_warnings?
Grazfather
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description/Motivation/Screenshots
Simple PR to allow
@deprecatedwarning display to be toggled off via config.How Has This Been Tested?
make testChecklist
devbranch, notmaster.