Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very slightly simplify GEFs instruction finding api #828

Closed
wants to merge 2 commits into from
Closed

Conversation

theguy147
Copy link
Collaborator

@theguy147 theguy147 commented Feb 19, 2022

very slightly simplify GEFs instruction finding api

Description/Motivation/Screenshots

The "instruction finding api" of GEF is currently a little confusing. For example gef_get_instruction_at() and gef_current_instruction do basically the exact same thing (the only difference underneath being a generator used vs a list).
Furthermore some of those function names did not properly reflect the code: e.g. gef_current_instruction() does not return the current instruction but the instruction at a specified address.

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✔️
x86-64 ✔️
ARM ✖️
AARCH64 ✖️
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make test ✔️

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@stale
Copy link

stale bot commented Apr 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You can reopen it by adding a comment to this issue.

@stale stale bot added the stale label Apr 21, 2022
@stale
Copy link

stale bot commented May 21, 2022

This issue has been automatically closed because it has not had recent activity. If you are the owner of this issue, you can either re-open it and provide a more complete description; or create a new issue. Thank you for your contributions.

@stale stale bot closed this May 21, 2022
@hugsy hugsy deleted the insns branch June 19, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant