small fixes in reset_architecture() #834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugsy
requested changes
May 19, 2022
| @@ -3771,7 +3771,11 @@ def reset_architecture(arch: Optional[str] = None, default: Optional[str] = None | |||
| raise OSError(f"Specified arch {arch.upper()} is not supported") | |||
|
|
|||
| if not gef.binary: | |||
| gef.binary = get_elf_headers() | |||
| try: | |||
| gef.binary = get_elf_headers() | |||
There was a problem hiding this comment.
This seems like a bad idea: gef.binary is literally used all the time and safe-failing that way (i.e. allowing gef.binary to be None) would open up plenty of error scenario where we assume it can't be.
What are the reasons behind this?
|
I am closing this pull request based on the gef targetting ELF files in particular and the fact that the code is still being refactored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small fixes in reset_architecture()
Description/Motivation/Screenshots
I ran into some issues while trying to use https://github.com/bet4it/udbserver.
The patch includes small bug fixes in
reset_architecture(). The first is catching aRuntimeErrorif parsing the ELF header fails (in the case where the binary is not an ELF file), and the second one isarch_name.upper().How Has This Been Tested?
make testChecklist
devbranch, notmaster.