Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hinting fixes - part 3 #856

Merged
merged 2 commits into from Oct 2, 2022
Merged

Type hinting fixes - part 3 #856

merged 2 commits into from Oct 2, 2022

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Jun 28, 2022

Description/Motivation/Screenshots

  • Explicitly forcing args : argparse.Namespace as a result of parse_arguments

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 Replace with ✅ if tested
x86-64
ARM
AARCH64
MIPS
POWERPC
SPARC
RISC-V
make test

Checklist

  • My PR was done against the dev branch, not main.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@hugsy hugsy added this to the Release: next milestone Jun 28, 2022
@hugsy hugsy marked this pull request as ready for review October 2, 2022 20:38
@hugsy hugsy merged commit 1f49f8a into dev Oct 2, 2022
@hugsy hugsy deleted the more_type_hinting_fixes branch October 2, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant